refactor: widen section and sidebar, plain period text, Badge xs size for stack

This commit is contained in:
Ilia Mashkov
2026-05-18 13:07:01 +03:00
parent 37098be3c8
commit 979e2071d1
7 changed files with 19 additions and 11 deletions
@@ -64,10 +64,11 @@ describe('ExperienceCard', () => {
expect(screen.getByRole('heading', { level: 3 })).toHaveTextContent('Senior Developer');
});
it('period badge has brutal-border, bg-blue, text-cream, md size', () => {
it('period has left border accent styling', () => {
render(<ExperienceCard {...DEFAULT_PROPS} />);
const badge = screen.getByText('2021 2024');
expect(badge).toHaveClass('brutal-border', 'bg-blue', 'text-cream', 'px-4', 'py-2', 'text-sm');
const period = screen.getByText('2021 2024');
expect(period.tagName).toBe('P');
expect(period).toHaveClass('brutal-border-left', 'text-sm');
});
it('description renders via RichText with rich-text class', () => {
@@ -83,12 +84,13 @@ describe('ExperienceCard', () => {
});
describe('stack tags', () => {
it('renders stack tags in the sidebar', () => {
it('renders stack tags in the sidebar as xs outline badges', () => {
render(<ExperienceCard {...DEFAULT_PROPS} stack={['React', 'TypeScript']} />);
const react = screen.getByText('React');
const ts = screen.getByText('TypeScript');
expect(react.closest('.brutal-border-sidebar')).toBeInTheDocument();
expect(ts.closest('.brutal-border-sidebar')).toBeInTheDocument();
expect(react).toHaveClass('brutal-border', 'bg-transparent', 'px-2');
});
it('renders nothing extra when stack is empty', () => {
@@ -29,7 +29,7 @@ type Props = {
/**
* Work experience card with sidebar layout.
* Sidebar: period badge, company, stack tags.
* Sidebar: period, company, stack tags.
* Main: job title and rich-text description.
*/
export function ExperienceCard({ title, company, period, description, stack, className }: Props) {
@@ -38,12 +38,12 @@ export function ExperienceCard({ title, company, period, description, stack, cla
<CardSidebar
sidebar={
<div className="flex flex-col gap-4">
<Badge size="md">{period}</Badge>
<p className="text-sm font-medium brutal-border-left pl-3">{period}</p>
<p className="text-base font-medium">{company}</p>
{stack.length > 0 && (
<div className="flex flex-wrap gap-2">
{stack.map((tech) => (
<Badge key={tech} variant="outline">
<Badge key={tech} variant="outline" size="xs">
{tech}
</Badge>
))}
+1 -1
View File
@@ -80,7 +80,7 @@
/* === GRID === */
--grid-gap: var(--space-3);
--section-content-width: 56rem;
--section-content-width: 72rem;
/* === ANIMATION === */
--ease-default: ease;
+5
View File
@@ -48,6 +48,11 @@ describe('Badge', () => {
expect(screen.getByText('Tag')).toHaveClass('px-3', 'py-1', 'text-xs');
});
it('applies xs size classes', () => {
render(<Badge size="xs">Tag</Badge>);
expect(screen.getByText('Tag')).toHaveClass('px-2', 'py-0.5');
});
it('applies sm size classes', () => {
render(<Badge size="sm">Tag</Badge>);
expect(screen.getByText('Tag')).toHaveClass('px-3', 'py-1', 'text-xs');
+2 -1
View File
@@ -2,7 +2,7 @@ import type { ReactNode } from 'react';
import { cn } from '$shared/lib';
export type BadgeVariant = 'default' | 'primary' | 'secondary' | 'outline';
export type BadgeSize = 'sm' | 'md';
export type BadgeSize = 'xs' | 'sm' | 'md';
interface Props {
/**
@@ -33,6 +33,7 @@ const VARIANTS: Record<BadgeVariant, string> = {
};
const SIZES: Record<BadgeSize, string> = {
xs: 'px-2 py-0.5 text-[10px]',
sm: 'px-3 py-1 text-xs',
md: 'px-4 py-2 text-sm',
};
+1 -1
View File
@@ -100,7 +100,7 @@ describe('CardSidebar', () => {
it('sidebar column has fixed width on md', () => {
render(<CardSidebar sidebar={<span>Sidebar</span>}>Main</CardSidebar>);
const sidebar = screen.getByText('Sidebar').parentElement;
expect(sidebar).toHaveClass('md:w-52');
expect(sidebar).toHaveClass('md:w-64');
});
it('main column fills remaining space', () => {
+1 -1
View File
@@ -109,7 +109,7 @@ interface CardSidebarProps {
export function CardSidebar({ sidebar, children, className }: CardSidebarProps) {
return (
<div className={cn('flex flex-col md:flex-row', className)}>
<div className="shrink-0 md:w-52 brutal-border-sidebar pb-6 md:pb-0 md:pr-8 mb-6 md:mb-0">{sidebar}</div>
<div className="shrink-0 md:w-64 brutal-border-sidebar pb-6 md:pb-0 md:pr-8 mb-6 md:mb-0">{sidebar}</div>
<div className="flex-1 min-w-0 md:pl-8">{children}</div>
</div>
);