feat: add Link secondary variant with border-bottom at sm+

Secondary variant drops text-decoration, uses opacity-60/hover-100
and brutal-border-bottom at sm+ for use in icon+label links where
the underline should only appear alongside the label.
This commit is contained in:
Ilia Mashkov
2026-05-19 18:06:10 +03:00
parent 954b17d824
commit 41af0b90a0
4 changed files with 96 additions and 25 deletions
+35 -16
View File
@@ -10,31 +10,50 @@ export default meta;
type Story = StoryObj<typeof Link>; type Story = StoryObj<typeof Link>;
export const Internal: Story = { const decorator = (Story: React.ComponentType) => (
<div className="p-8 bg-cream">
<Story />
</div>
);
export const Primary: Story = {
args: { args: {
href: '/about', href: '/about',
children: 'Internal page', children: 'Internal page',
}, },
decorators: [ decorators: [decorator],
(Story) => (
<div className="p-8 bg-cream">
<Story />
</div>
),
],
}; };
export const External: Story = { export const PrimaryExternal: Story = {
args: { args: {
href: 'https://example.com', href: 'https://example.com',
external: true, external: true,
children: 'External site', children: 'External site',
}, },
decorators: [ decorators: [decorator],
(Story) => ( };
<div className="p-8 bg-cream">
<Story /> export const Secondary: Story = {
</div> args: {
), href: 'https://github.com',
], external: true,
variant: 'secondary',
children: 'GitHub',
},
decorators: [decorator],
};
export const SecondaryWithIcon: Story = {
args: {
href: 'https://github.com',
external: true,
variant: 'secondary',
className: 'flex items-center gap-1.5 text-sm',
children: (
<>
<span className="hidden sm:block">GitHub</span>
</>
),
},
decorators: [decorator],
}; };
+41 -5
View File
@@ -10,7 +10,8 @@ import { render, screen } from '@testing-library/react';
import type React from 'react'; import type React from 'react';
import { Link } from './Link'; import { Link } from './Link';
const BASE = 'underline underline-offset-2 hover:opacity-60 transition-opacity'; const PRIMARY = 'underline underline-offset-2 hover:opacity-60 transition-opacity';
const SECONDARY = 'no-underline opacity-60 hover:opacity-100 sm:brutal-border-bottom transition-opacity';
describe('internal link', () => { describe('internal link', () => {
it('renders an anchor element', () => { it('renders an anchor element', () => {
@@ -28,10 +29,10 @@ describe('internal link', () => {
expect(screen.getByRole('link', { name: 'About' })).not.toHaveAttribute('target'); expect(screen.getByRole('link', { name: 'About' })).not.toHaveAttribute('target');
}); });
it('applies base classes', () => { it('applies primary classes by default', () => {
render(<Link href="/about">About</Link>); render(<Link href="/about">About</Link>);
const link = screen.getByRole('link', { name: 'About' }); const link = screen.getByRole('link', { name: 'About' });
for (const cls of BASE.split(' ')) { for (const cls of PRIMARY.split(' ')) {
expect(link).toHaveClass(cls); expect(link).toHaveClass(cls);
} }
}); });
@@ -66,8 +67,43 @@ describe('external link', () => {
}); });
}); });
describe('variant', () => {
it('primary applies underline classes', () => {
render(
<Link href="/about" variant="primary">
About
</Link>,
);
const link = screen.getByRole('link', { name: 'About' });
for (const cls of PRIMARY.split(' ')) {
expect(link).toHaveClass(cls);
}
});
it('secondary applies secondary classes', () => {
render(
<Link href="/about" variant="secondary">
About
</Link>,
);
const link = screen.getByRole('link', { name: 'About' });
for (const cls of SECONDARY.split(' ')) {
expect(link).toHaveClass(cls);
}
});
it('secondary does not apply underline', () => {
render(
<Link href="/about" variant="secondary">
About
</Link>,
);
expect(screen.getByRole('link', { name: 'About' })).not.toHaveClass('underline');
});
});
describe('className passthrough', () => { describe('className passthrough', () => {
it('merges custom className with base classes', () => { it('merges custom className with variant classes', () => {
render( render(
<Link href="/about" className="text-red-500"> <Link href="/about" className="text-red-500">
Styled Styled
@@ -75,7 +111,7 @@ describe('className passthrough', () => {
); );
const link = screen.getByRole('link', { name: 'Styled' }); const link = screen.getByRole('link', { name: 'Styled' });
expect(link).toHaveClass('text-red-500'); expect(link).toHaveClass('text-red-500');
for (const cls of BASE.split(' ')) { for (const cls of PRIMARY.split(' ')) {
expect(link).toHaveClass(cls); expect(link).toHaveClass(cls);
} }
}); });
+18 -4
View File
@@ -2,6 +2,8 @@ import NextLink from 'next/link';
import type { ReactNode } from 'react'; import type { ReactNode } from 'react';
import { cn } from '$shared/lib'; import { cn } from '$shared/lib';
export type LinkVariant = 'primary' | 'secondary';
/** /**
* Props for Link. * Props for Link.
*/ */
@@ -18,6 +20,13 @@ interface Props {
* CSS classes * CSS classes
*/ */
className?: string; className?: string;
/**
* Visual variant.
* primary — text-decoration underline.
* secondary — border-bottom at sm+, no underline on mobile (for icon+label links).
* @default 'primary'
*/
variant?: LinkVariant;
/** /**
* When true, renders a plain <a> with target="_blank" rel="noopener noreferrer". * When true, renders a plain <a> with target="_blank" rel="noopener noreferrer".
* Use for links that open outside the app. * Use for links that open outside the app.
@@ -25,22 +34,27 @@ interface Props {
external?: boolean; external?: boolean;
} }
const BASE = 'underline underline-offset-2 hover:opacity-60 transition-opacity'; const VARIANTS = {
primary: 'underline underline-offset-2 hover:opacity-60 transition-opacity',
secondary: 'no-underline opacity-60 hover:opacity-100 sm:brutal-border-bottom transition-opacity',
} as const satisfies Record<LinkVariant, string>;
/** /**
* Inline text link. * Inline text link.
* Renders as Next.js Link for internal routes, plain <a> for external links. * Renders as Next.js Link for internal routes, plain <a> for external links.
*/ */
export function Link({ href, children, className, external }: Props) { export function Link({ href, children, className, variant = 'primary', external }: Props) {
const cls = cn(VARIANTS[variant], className);
if (external) { if (external) {
return ( return (
<a href={href} target="_blank" rel="noopener noreferrer" className={cn(BASE, className)}> <a href={href} target="_blank" rel="noopener noreferrer" className={cls}>
{children} {children}
</a> </a>
); );
} }
return ( return (
<NextLink href={href} className={cn(BASE, className)}> <NextLink href={href} className={cls}>
{children} {children}
</NextLink> </NextLink>
); );
+2
View File
@@ -5,7 +5,9 @@ export { Button } from './Button';
export type { CardBackground } from './Card'; export type { CardBackground } from './Card';
export { Card, CardContent, CardDescription, CardFooter, CardHeader, CardSidebar, CardTitle } from './Card'; export { Card, CardContent, CardDescription, CardFooter, CardHeader, CardSidebar, CardTitle } from './Card';
export { InlineSvg } from './InlineSvg';
export { Input, Textarea } from './Input'; export { Input, Textarea } from './Input';
export type { LinkVariant } from './Link';
export { Link } from './Link'; export { Link } from './Link';
export { RichText } from './RichText'; export { RichText } from './RichText';
export type { ContainerSize, SectionBackground } from './Section'; export type { ContainerSize, SectionBackground } from './Section';